Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support grpc-gateway #405

Merged
merged 7 commits into from
Nov 30, 2022
Merged

feat: support grpc-gateway #405

merged 7 commits into from
Nov 30, 2022

Conversation

sysulq
Copy link
Member

@sysulq sysulq commented Sep 2, 2022

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Merging #405 (579db78) into master (4f8bd4e) will increase coverage by 0.11%.
The diff coverage is n/a.

❗ Current head 579db78 differs from pull request most recent head 960c423. Consider uploading reports for the commit 960c423 to get more accurate results

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   52.01%   52.12%   +0.11%     
==========================================
  Files         105      105              
  Lines        6973     6973              
==========================================
+ Hits         3627     3635       +8     
+ Misses       3080     3071       -9     
- Partials      266      267       +1     
Impacted Files Coverage Δ
pkg/registry/etcdv3/registry.go 74.22% <0.00%> (+2.74%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@stale
Copy link

stale bot commented Nov 5, 2022

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time. Thank you for your contributions.

@stale stale bot added the stale label Nov 5, 2022
@stale
Copy link

stale bot commented Nov 30, 2022

This pull request/issue is no longer marked as stale.

@stale stale bot removed the stale label Nov 30, 2022
@sysulq sysulq merged commit d63062f into master Nov 30, 2022
@sysulq sysulq added the enhancement New feature or request label Nov 30, 2022
@sysulq sysulq deleted the feat/grpc-gateway branch November 30, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants