Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search doesn't work with upper-case #28

Closed
Charlie91 opened this issue Nov 15, 2017 · 5 comments
Closed

Search doesn't work with upper-case #28

Charlie91 opened this issue Nov 15, 2017 · 5 comments
Labels

Comments

@Charlie91
Copy link

You can see this even in the example.
https://dowjones.github.io/react-dropdown-tree-select/
If you type in on search field something in uppercase the field will write "No matches found".
I think it is not supposed to be that way

@mrchief
Copy link
Collaborator

mrchief commented Nov 15, 2017

Actually search is case sensitive. But I can see how one might want it to be case insensitive. Maybe an option to make it case insensitive? I might be able to get to it later this week or I would love to have a PR on this.

@Charlie91
Copy link
Author

Charlie91 commented Nov 15, 2017

@mrchief
No, check this gif
http://dropmefiles.com/GFb2T
For example, if i have an option like "RSVP" and "RSVP" is typed in search - it isn't appear in results.
It only appears if i typed "rsvp" in lowercase

@mrchief
Copy link
Collaborator

mrchief commented Nov 15, 2017

Ahh, that seems like a bug. I'll check this and get back to you. Thanks for the GIF!

@mrchief mrchief added the bug label Nov 15, 2017
@mrchief
Copy link
Collaborator

mrchief commented Nov 15, 2017

If you want to take a shot at a PR, please feel free. The offending lines are: here and here

@mrchief
Copy link
Collaborator

mrchief commented Nov 16, 2017

Try with v1.0.4. Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants