feat: Support placeholder for inline search input

[ldeveber]

What does it do?

Adds option texts.inlineSearchPlaceholder to customize the placeholder text for the inline search input

Fixes # (issue)

Closes #388

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)
• This change requires a documentation update

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• Updated documentation (if applicable)
• Added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• My changes generate no new warnings

[coveralls]

Pull Request Test Coverage Report for Build 1509

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.06%) to 93.901%

---

Totals
Change from base Build 1495:	-0.06%
Covered Lines:	598
Relevant Lines:	619

---

💛 - Coveralls

[mrchief]

@ldeveber I'm wondering if we can do this without adding one more option. What if we hide the original placeholder when inline option is set? What's the point of having 2 placeholders?

[ldeveber]

@ldeveber I'm wondering if we can do this without adding one more option. What if we hide the original placeholder when inline option is set? What's the point of having 2 placeholders?

@mrchief Because the UX I need to support is:

where it needs to say "Select a field..." and "Search"

[ldeveber]

@ldeveber I'm wondering if we can do this without adding one more option. What if we hide the original placeholder when inline option is set? What's the point of having 2 placeholders?

@mrchief Because the UX I need to support is:

where it needs to say "Select a field..." and "Search"

@mrchief bump :(

[mrchief]

@ldeveber It hasn't dropped from my radar. Things have been busy lately but I have been going thru options to see if there's something more we can do.

[ldeveber]

@ldeveber It hasn't dropped from my radar. Things have been busy lately but I have been going thru options to see if there's something more we can do.

@mrchief any updates?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ldeveber]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@mrchief any updates? :(

[mrchief]

@ldeveber sorry about the delay. The PR looks good. I'm thinking if it'd be helpful to add it to Options playground.

You can add that under docs/src/stories/Options and the netlify status check will let you preview your branch changes.

[ldeveber]

@ldeveber sorry about the delay. The PR looks good. I'm thinking if it'd be helpful to add it to Options playground.

You can add that under docs/src/stories/Options and the netlify status check will let you preview your branch changes.

Oh neat. I will update this :)

[codeclimate]

Code Climate has analyzed commit 7141fb0 and detected 0 issues on this pull request.

View more on Code Climate.

[ldeveber]

@ldeveber sorry about the delay. The PR looks good. I'm thinking if it'd be helpful to add it to Options playground.

@mrchief All set! :)

NOTE: this is after changing the text, not the defaults haha :)

[mrchief]

@ldeveber I see you added the option for placeholder text as well, thanks for that! This looks good! I'll try to get it out this weekend.

[github-actions]

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀