Improvement: remove usage of !important to remove the padding of nodes during search #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gregcop1
force-pushed
the
fix-remove-important
branch
2 times, most recently
from
0f1aa89
to
43cc857
Compare
… search to avoid cascading !important in css, it's better to not use it at first.
Gregcop1
force-pushed
the
fix-remove-important
branch
from
43cc857
to
fa7fc5d
Compare
Gregcop1
force-pushed
the
fix-remove-important
branch
3 times, most recently
from
0c30167
to
1a2d51a
Compare
Gregcop1
force-pushed
the
fix-remove-important
branch
from
1a2d51a
to
0b63d51
Compare
|
@Gregcop1 Thanks for sending this PR. Just running few tests locally. If everything checks out, I'll merge this soon. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: remove cascading
!importantin css for hidden nodes (it's repaced by JS conditional style and allow to override this behaviour easily)feat: add a "keepTreeOnSearch" prop to display results as a tree instead of flattening them (parent that don't match but with children which match are displayed with a specific class (ATM, it reduces opacity too))