Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add no matches text in parameter #62

Merged
merged 2 commits into from
Mar 24, 2018
Merged

feat: Add no matches text in parameter #62

merged 2 commits into from
Mar 24, 2018

Conversation

toofff
Copy link
Contributor

@toofff toofff commented Mar 15, 2018 •
edited
Loading

I put this parametrable text so that it can be translated into any language.

Does this feature seem interesting to you for your plugin?

@coveralls
Copy link

coveralls commented Mar 15, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 99.636% when pulling f2dde02 on toofff:feature/add-variable-for-error into 5b76362 on dowjones:master.

mrchief
mrchief suggested changes Mar 15, 2018
View reviewed changes
Copy link
Collaborator

@mrchief mrchief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you please add a unit test to check the same?

@toofff
Copy link
Contributor Author

toofff commented Mar 16, 2018

@mrchief ok i'm looking at this today

@mrchief mrchief merged commit 3817ed8 into dowjones:master Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrchief mrchief mrchief approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toofff @coveralls @mrchief