Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-402] design feedback for media embeds #1201

Merged
merged 1 commit into from
Jun 4, 2024
Merged

[R20-402] design feedback for media embeds #1201

merged 1 commit into from
Jun 4, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jun 3, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-402

What I did

  • Design feedback for media embeds

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jun 3, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 3, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 4a3932d
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/665d69935294f20008a4ff2a

@cypress Cypress
Copy link

cypress bot commented Jun 3, 2024

Passing run #1841 ↗︎

0 160 0 0 Flakiness 0

Details:

feat(@dpc-sdp/ripple-ui-core): design feedback for media embeds
Project: ripple-framework Commit: 4a3932d49b
Status: Passed Duration: 07:21 💡
Started: Jun 3, 2024 6:58 AM Ended: Jun 3, 2024 7:06 AM

Review all test suite changes for PR #1201 ↗︎

@lambry lambry added this pull request to the merge queue Jun 4, 2024
Merged via the queue into develop with commit f801cb9 Jun 4, 2024
15 of 16 checks passed
@lambry lambry deleted the feature/R20-402-media-embed-feedback branch June 4, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle jeffdowdle approved these changes

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lambry @waitingallday @dylankelly @jeffdowdle