Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-2016] Added underlines to pagination page links (design feedback) #1209

Merged
merged 1 commit into from
Jun 5, 2024
Merged

[R20-2016] Added underlines to pagination page links (design feedback) #1209

merged 1 commit into from
Jun 5, 2024

Conversation

jeffdowdle
Copy link
Contributor

Issue: https://digital-vic.atlassian.net/browse/R20-2016

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@jeffdowdle jeffdowdle self-assigned this Jun 4, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 4, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 8e6201f
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/665e989c6aad4c0008fcfb19

@cypress Cypress
Copy link

cypress bot commented Jun 4, 2024

Passing run #1855 ↗︎

0 161 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-ui-core): added underlines to pagination page links
Project: ripple-framework Commit: 8e6201f739
Status: Passed Duration: 06:31 💡
Started: Jun 4, 2024 4:33 AM Ended: Jun 4, 2024 4:39 AM

Review all test suite changes for PR #1209 ↗︎

@dylankelly dylankelly added this pull request to the merge queue Jun 5, 2024
Merged via the queue into develop with commit 410c696 Jun 5, 2024
15 of 16 checks passed
@dylankelly dylankelly deleted the bugfix/R20-2016-pagination-feedback branch June 5, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambry lambry lambry approved these changes

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

Assignees

@jeffdowdle jeffdowdle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffdowdle @lambry @waitingallday @dylankelly