Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1969] skeleton loading #1222

Merged
merged 4 commits into from
Jun 20, 2024
Merged

[R20-1969] skeleton loading #1222

merged 4 commits into from
Jun 20, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jun 17, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-1969

What I did

  • Add skeleton loading states
  • Scroll to results on submit (can be turned off via prop)
  • Fix table display when sidebar is present
    table-with-sidebar
  • Fix tally/sort spacing
    compact-above-search-spacing

Listing skeleton loaders

sl-skeletons.mov

Map skeleton loaders

map-skeleton.mov

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added cypress tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jun 17, 2024
Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 55ad9b7
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6670c354c6c1ff00098ce623

Copy link

cypress bot commented Jun 17, 2024

Passing run #1919 ↗︎

0 170 0 0 Flakiness 0

Details:

refactor(@dpc-sdp/ripple-tide-search): update table skeleton, fix background col...
Project: ripple-framework Commit: 55ad9b7573
Status: Passed Duration: 07:43 💡
Started: Jun 17, 2024 11:16 PM Ended: Jun 17, 2024 11:24 PM

Review all test suite changes for PR #1222 ↗︎

@dylankelly dylankelly added this pull request to the merge queue Jun 20, 2024
Merged via the queue into develop with commit b5870ac Jun 20, 2024
15 of 16 checks passed
@dylankelly dylankelly deleted the feature/skeleton-loading branch June 20, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants