Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@dpc-sdp/ripple-ui-core): set firstLoad in finally block #1239

Merged
merged 1 commit into from
Jun 28, 2024
Merged

fix(@dpc-sdp/ripple-ui-core): set firstLoad in finally block #1239

merged 1 commit into from
Jun 28, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jun 26, 2024

What I did

  • Always update firstLoad

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jun 26, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 26, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 876b84e
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/667ca55b7566150008dcb763

@dylankelly dylankelly added this pull request to the merge queue Jun 28, 2024
Merged via the queue into develop with commit e6baaf9 Jun 28, 2024
8 checks passed
@dylankelly dylankelly deleted the bugfix/map-first-load branch June 28, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle jeffdowdle approved these changes

@waitingallday waitingallday Awaiting requested review from waitingallday

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @dylankelly @jeffdowdle