Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1602][R20-1608] published by label #1243

Merged
merged 2 commits into from
Jul 1, 2024
Merged

[R20-1602][R20-1608] published by label #1243

merged 2 commits into from
Jul 1, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jul 1, 2024

Issues:
https://digital-vic.atlassian.net/browse/R20-1602
https://digital-vic.atlassian.net/browse/R20-1608

What I did

  • Update published by label, i.e. news and publications now say 'Published by' instead of 'Department' and 'Author'

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added cypress tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jul 1, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 1, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 4670454
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/66833ee8091b3a000894e79b

@dylankelly dylankelly enabled auto-merge July 1, 2024 23:56
@dylankelly dylankelly added this pull request to the merge queue Jul 1, 2024
Merged via the queue into develop with commit c976b7a Jul 1, 2024
8 checks passed
@dylankelly dylankelly deleted the feature/published-by-label branch July 1, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle jeffdowdle approved these changes

@waitingallday waitingallday Awaiting requested review from waitingallday

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @dylankelly @jeffdowdle