Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1985] add custom content rating text #1250

Merged
merged 3 commits into from
Jul 25, 2024
Merged

[R20-1985] add custom content rating text #1250

merged 3 commits into from
Jul 25, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jul 4, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-1985

What I did

  • Add custom content rating text

PENDING: Backend release https://digital-vic.atlassian.net/browse/SDPAP-9240

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added cypress tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jul 4, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 4, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 583aac7
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/669d91540044a90008ba68b0

@cypress Cypress
Copy link

cypress bot commented Jul 15, 2024 •
edited
Loading

Passing run #2086 ↗︎

0 181 0 0 Flakiness 0

Details:

Merge branch 'develop' into feature/R20-1985-content-rating-text
Project: ripple-framework Commit: 583aac72f1
Status: Passed Duration: 07:43 💡
Started: Jul 21, 2024 10:55 PM Ended: Jul 21, 2024 11:03 PM

Review all test suite changes for PR #1250 ↗︎

@lambry lambry requested a review from dylankelly July 15, 2024 01:03
Merge branch 'develop' into feature/R20-1985-content-rating-text
583aac7 
# Conflicts:
#	packages/nuxt-ripple/mapping/site/index.ts
@dylankelly dylankelly added this to the 2.13.0 milestone Jul 24, 2024
@dylankelly dylankelly changed the base branch from develop to release/v2.13.0 July 24, 2024 23:58
@dylankelly dylankelly merged commit 13f8e65 into release/v2.13.0 Jul 25, 2024
15 of 16 checks passed
@dylankelly dylankelly deleted the feature/R20-1985-content-rating-text branch July 25, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @dylankelly