Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup some console/linter warnings #1268

Merged
merged 2 commits into from
Jul 25, 2024
Merged

chore: cleanup some console/linter warnings #1268

merged 2 commits into from
Jul 25, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jul 19, 2024

What I did

  • Cleanup some console/linter warnings

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jul 19, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 19, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 3449bf9
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/669d90942e106e00087eb022

@cypress Cypress
Copy link

cypress bot commented Jul 19, 2024 •
edited
Loading

Passing run #2085 ↗︎

0 179 0 0 Flakiness 0

Details:

Merge branch 'develop' into feature/cleanup-some-warnings
Project: ripple-framework Commit: 3449bf9bb0
Status: Passed Duration: 07:31 💡
Started: Jul 21, 2024 10:52 PM Ended: Jul 21, 2024 10:59 PM

Review all test suite changes for PR #1268 ↗︎

@dylankelly dylankelly assigned dylankelly and unassigned dylankelly Jul 24, 2024
@waitingallday waitingallday added this to the 2.13.0 milestone Jul 24, 2024
@dylankelly dylankelly changed the base branch from develop to release/v2.13.0 July 24, 2024 23:58
@dylankelly dylankelly merged commit 66bb606 into release/v2.13.0 Jul 25, 2024
16 checks passed
@dylankelly dylankelly deleted the feature/cleanup-some-warnings branch July 25, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @dylankelly