Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-730] add fallback origin in dataLayer for relative URLs #1270

Merged
merged 1 commit into from
Jul 22, 2024
Merged

[R20-730] add fallback origin in dataLayer for relative URLs #1270

merged 1 commit into from
Jul 22, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jul 21, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-730

What I did

  • add fallback origin in dataLayer for relative URLs

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jul 21, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 21, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 76ee3d1
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/669d907d32bff7000816cba6

@lambry lambry added this pull request to the merge queue Jul 22, 2024
Merged via the queue into develop with commit 560ddc1 Jul 22, 2024
8 checks passed
@lambry lambry deleted the bugfix/data-layer-download-domain branch July 22, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @dylankelly