Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(nuxt-app): adding tests for analytics events #1271

Merged
merged 2 commits into from
Jul 25, 2024
Merged

test(nuxt-app): adding tests for analytics events #1271

merged 2 commits into from
Jul 25, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jul 21, 2024

What I did

  • Start adding tests for analytics events

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jul 21, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 22, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 2d9bad7
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/669ef562e80a8b00082d0f7a

@cypress Cypress
Copy link

cypress bot commented Jul 22, 2024 •
edited
Loading

Passing run #2092 ↗︎

0 181 0 0 Flakiness 0

Details:

Merge branch 'develop' into feature/analytics-tests
Project: ripple-framework Commit: 2d9bad7af7
Status: Passed Duration: 08:41 💡
Started: Jul 23, 2024 12:15 AM Ended: Jul 23, 2024 12:23 AM

Review all test suite changes for PR #1271 ↗︎

@lambry lambry marked this pull request as ready for review July 24, 2024 00:35
@dylankelly dylankelly added this to the 2.13.0 milestone Jul 24, 2024
@dylankelly dylankelly changed the base branch from develop to release/v2.13.0 July 24, 2024 23:59
@dylankelly dylankelly merged commit 5ccbcf6 into release/v2.13.0 Jul 25, 2024
8 checks passed
@dylankelly dylankelly deleted the feature/analytics-tests branch July 25, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@waitingallday waitingallday Awaiting requested review from waitingallday

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lambry @dylankelly