Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-83] external redirects #1272

Merged
merged 2 commits into from
Jul 25, 2024
Merged

[SD-83] external redirects #1272

merged 2 commits into from
Jul 25, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jul 23, 2024

Issue
https://digital-vic.atlassian.net/browse/SD-83
https://digital-vic.atlassian.net/browse/SD-81

What I did

  • add support for new field: field_redirect_website, we used to have a check here for field_node_link but that field was used for different purposes. The new field will always redirect the site.

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added cypress tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jul 23, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 23, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit badd972
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/669f4714762be900080a3d53

@waitingallday waitingallday added this to the 2.13.0 milestone Jul 24, 2024
@dylankelly dylankelly changed the base branch from develop to release/v2.13.0 July 24, 2024 23:58
@dylankelly dylankelly merged commit 707ba8d into release/v2.13.0 Jul 25, 2024
8 checks passed
@dylankelly dylankelly deleted the feature/SDPAP-9389-external-redirects branch July 25, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle jeffdowdle approved these changes

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lambry @waitingallday @dylankelly @jeffdowdle