Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDPSUP-7562] add siteSearchContentTypes featureFlag #1274

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jul 23, 2024

Issue: https://digital-vic.atlassian.net/browse/SDPSUP-7562

What I did

  • Add feature flag to allow management of site search content types;
    • disable a default content type search.contentTypes.grant: false
    • enable a extra content type search.contentTypes.product: true

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added cypress tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jul 23, 2024
Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 4cb50a5
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/66a06a072223580008884ccd

Copy link

cypress bot commented Jul 24, 2024

Passing run #2104 ↗︎

0 184 0 0 Flakiness 0

Details:

Merge branch 'release/v2.13.0' into feature/site-search-feature-flags
Project: ripple-framework Commit: ecc70b9838
Status: Passed Duration: 07:44 💡
Started: Jul 25, 2024 12:27 AM Ended: Jul 25, 2024 12:35 AM

Review all test suite changes for PR #1274 ↗︎

@dylankelly dylankelly added this to the 2.13.0 milestone Jul 24, 2024
@dylankelly dylankelly changed the base branch from develop to release/v2.13.0 July 25, 2024 00:00
# Conflicts:
#	packages/ripple-tide-search/components/TideSearchPage.vue
@dylankelly dylankelly merged commit 8377be7 into release/v2.13.0 Jul 26, 2024
14 checks passed
@dylankelly dylankelly deleted the feature/site-search-feature-flags branch July 26, 2024 00:05
@cypress cypress bot mentioned this pull request Jul 26, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants