Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@dpc-sdp/ripple-tide-search): allow address search function to be customised via JSON #1278

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

jeffdowdle
Copy link
Contributor

Issue:

What I did

  • Made the max number of suburb and address suggestions customisable
  • It seems like different maps will have different values, so this makes it easy to change without a deployment,

How to test

  • Example config:
    "locationQueryConfig": {
      "component": "TideSearchAddressLookup",
      "props": {
        "controlMapZooming": false,
        "label": "Search by suburb or postcode",
        "placeholder": "Enter suburb or postcode",
        "suggestionsConfig": {
          "function": "rplAddressSuggestionsFn",
          "args": {
            "maxSuburbSuggestions": 5,
            "maxAddressSuggestions": 10
          }
        }
        ...
    

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@waitingallday waitingallday added this to the 2.13.0 milestone Jul 25, 2024
Copy link

cypress bot commented Jul 25, 2024

Passing run #2105 ↗︎

0 183 0 0 Flakiness 0

Details:

feat(@dpc-sdp/ripple-tide-search): allow address search function to be customise...
Project: ripple-framework Commit: 695b18cd1d
Status: Passed Duration: 09:02 💡
Started: Jul 25, 2024 4:25 AM Ended: Jul 25, 2024 4:34 AM

Review all test suite changes for PR #1278 ↗︎

@dylankelly dylankelly merged commit d58b081 into release/v2.13.0 Jul 26, 2024
6 checks passed
@dylankelly dylankelly deleted the feature/SD-74-suggestions branch July 26, 2024 00:03
@cypress cypress bot mentioned this pull request Jul 26, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants