Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-129] map results hook firing before map is ready #1298

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Aug 20, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-129

What I did

  • Fix for first map results hook firing before map is ready

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added cypress tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Aug 20, 2024
@waitingallday waitingallday added this to the 2.15.0 milestone Aug 20, 2024
David Featherston added 2 commits August 20, 2024 10:25
Copy link

cypress bot commented Aug 21, 2024



Test summary

190 0 0 0


Run details

Project ripple-framework
Status Passed
Commit a3238e4
Started Aug 21, 2024 11:47 PM
Ended Aug 21, 2024 11:55 PM
Duration 08:44 💡
OS Linux Ubuntu -
Browser Electron 118

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@lambry lambry merged commit b816389 into release/2.15.0 Aug 22, 2024
6 checks passed
@lambry lambry deleted the bugfix/initial-map-results-hook branch August 22, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants