Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin es dependency versions #1300

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Conversation

dylankelly
Copy link
Contributor

Issue:

What I did

  • ES dependencies are being pinned in all projects due to change in export upstream. I'd like to be able to remove this at the project level

How to test

  • build project without pinned es version, needs to be installed into other project as workspace imports dont have the same issue

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@dylankelly dylankelly self-assigned this Aug 21, 2024
@waitingallday waitingallday added this to the 2.15.0 milestone Aug 22, 2024
Copy link

cypress bot commented Aug 22, 2024

ripple-framework    Run #2168

Run Properties:  status check passed Passed #2168  •  git commit e10bd47d74: chore(@dpc-sdp/nuxt-ripple-cli): remove pinned es versions
Project ripple-framework
Branch Review feature/es-version-pin
Run status status check passed Passed #2168
Run duration 08m 09s
Commit git commit e10bd47d74: chore(@dpc-sdp/nuxt-ripple-cli): remove pinned es versions
Committer dylankelly
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 188
View all changes introduced in this branch ↗︎

@dylankelly dylankelly merged commit 32fe253 into release/2.15.0 Aug 27, 2024
6 checks passed
@dylankelly dylankelly deleted the feature/es-version-pin branch August 27, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants