Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-187] Data table html header labels #1316

Merged
merged 1 commit into from
Sep 6, 2024
Merged

[SD-187] Data table html header labels #1316

merged 1 commit into from
Sep 6, 2024

Conversation

waitingallday
Copy link
Member

Issue: https://digital-vic.atlassian.net/browse/SD-187

What I did

  • Added column config prop isLabelHTML and support for rendering HTML in table headings

Screenshot 2024-09-05 at 4 06 04 PM

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@waitingallday waitingallday added this to the 2.16.0 milestone Sep 5, 2024
@waitingallday waitingallday self-assigned this Sep 5, 2024
@cypress Cypress
Copy link

cypress bot commented Sep 5, 2024

ripple-framework    Run #2189

Run Properties:  status check passed Passed #2189  •  git commit c4559b52a2: feat(@dpc-sdp/ripple-ui-core): :sparkles: support html heading
Project ripple-framework
Branch Review feat/sd-187-data-table-html-headers
Run status status check passed Passed #2189
Run duration 08m 32s
Commit git commit c4559b52a2: feat(@dpc-sdp/ripple-ui-core): :sparkles: support html heading
Committer Jason Smith
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 193
View all changes introduced in this branch ↗︎

lambry
lambry approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@lambry lambry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, It just works in search listing result tables as well.

@dylankelly dylankelly merged commit 9c6d98e into release/2.16.0 Sep 6, 2024
13 of 14 checks passed
@dylankelly dylankelly deleted the feat/sd-187-data-table-html-headers branch September 6, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambry lambry lambry approved these changes

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@waitingallday waitingallday

Labels
None yet
Projects
None yet
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@waitingallday @lambry @dylankelly