[SD-172] Added support for CAPTCHAs in webforms #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdowdle
commented
Sep 10, 2024
| </script> | ||
| <template> | ||
| <div v-if="captchaElementId" :id="captchaElementId"></div> |
There was a problem hiding this comment.
If applicable, the captcha checkbox/badge will be rendered here
jeffdowdle
commented
Sep 10, 2024
| } | ||
| } | ||
|
|
||
| export const getCaptchaResponse = async ( |
There was a problem hiding this comment.
This is called on submit of the form to get the captcha token
jeffdowdle
commented
Sep 10, 2024
jeffdowdle
commented
Sep 10, 2024
| @@ -29,7 +37,8 @@ export function useWebformSubmit(formId: string) { | |||
| site: config.tide.site | |||
| }, | |||
| headers: { | |||
| 'Content-Type': 'application/vnd.api+json;charset=UTF-8' | |||
| 'Content-Type': 'application/vnd.api+json;charset=UTF-8', | |||
| 'x-captcha-response': maybeCaptchaResponse || undefined | |||
There was a problem hiding this comment.
The captcha token is sent via a header to the nuxt server endpoint
jeffdowdle
commented
Sep 10, 2024
| } | ||
| } | ||
|
|
||
| const verifyCaptcha = async (event: H3Event) => { |
There was a problem hiding this comment.
This is where we take the token generated in the browser and validate it which the CAPTCHA provider, this needs to happen server side.
We have to get the webform from drupal here to check if the captcha is enabled or not.
ripple-framework
|
||||||||||||||||||||||||||||
| Project |
ripple-framework
|
| Branch Review |
feature/SD-172-captcha-support
|
| Run status |
|
| Run duration | 08m 37s |
| Commit |
|
| Committer | Jeffrey Dowdle |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
196
|
| View all changes introduced in this branch ↗︎ | |
…upport multiple on a page
…pc-sdp/ripple-framework into feature/SD-172-captcha-support
…ting form changes
lambry
reviewed
Sep 17, 2024
…red to be less finnicky
…pc-sdp/ripple-framework into feature/SD-172-captcha-support
…ptcha element is rendered this supports the content rating form, otherwise the third party scripts are loaded always on every page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://digital-vic.atlassian.net/browse/SD-172
What I did
How to test
Checklist
For all PR's
For new components only