[SD-314] Breadcrumbs enhancement #1329
Open
+65
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambry
reviewed
Sep 17, 2024
| class="rpl-breadcrumbs__collapse-link" | ||
| > | ||
| <RplTextLink | ||
| url="" |
There was a problem hiding this comment.
Hey, can this be a button (then we won't need the url) with an aria-label? Cheers
There was a problem hiding this comment.
Oh yeah, good pick up!
lambry
approved these changes
Sep 17, 2024
ripple-framework
|
||||||||||||||||||||||||||||
| Project |
ripple-framework
|
| Branch Review |
feat/breadcrumbs-update
|
| Run status |
|
| Run duration | 09m 32s |
| Commit |
|
| Committer | Jason Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
196
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://digital-vic.atlassian.net/browse/SD-314
What I did
How to test
Checklist
For all PR's
For new components only