[SRM-665] Ckeditor5 and Claro upgrade #100
Conversation
Co-authored-by: Vincent Gao <vincent.gao@dpc.vic.gov.au>
# Conflicts: # composer.json
vincent-gao
requested review from
krakerag,
anthony-malkoun,
mayurngondhkar,
MdNadimHossain,
yeniatencio and
edyuenyw
composer.json
Outdated
| "extra": { | ||
| "patches": { | ||
| "drupal/embed": { | ||
| "CKEditor 5 compatibility - https://www.drupal.org/project/embed/issues/3309747": "https://git.drupalcode.org/project/embed/-/merge_requests/2/diffs.patch" |
There was a problem hiding this comment.
This is a dangerous patch, as one commit to the PR will change the diff. If you can get a diff from a specific commit hash that would be safer.
There was a problem hiding this comment.
hey @krakerag , Thanks for the review.
for fixing the compatibility issue for ck5, it has several commits, so it seems impossible to get a patch for a specific commit and we want to include all of the changes.
I can remove diffs , it will be https://git.drupalcode.org/project/embed/-/merge_requests/2.patch
please advice.
https://git.drupalcode.org/project/embed/-/merge_requests/2/commits
There was a problem hiding this comment.
If someone pushes up another commit to that PR #2, your patch will change.
I would download the patch, add it as a comment to the issue, so that the uploaded patch cannot change. That's how we do it with regular patchfiles that don't use a PR.
There was a problem hiding this comment.
yes, that is correct.
will do.
Jira
https://digital-vic.atlassian.net/browse/SRM-665
Changes
drupal/video_embed_fieldto support CKeditor5.js/embed_media_back_button.jsto support CKeditor5Related PRs
dpc-sdp/tide_core#380
dpc-sdp/tide_grant#27
#100
dpc-sdp/tide_publication#30
dpc-sdp/tide_landing_page#197
dpc-sdp/tide_site#124