Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: interface query on m-m joins and select specific columns #1398

Merged
merged 28 commits into from
Jul 2, 2020

Conversation

dpgaspar
Copy link
Owner

@dpgaspar dpgaspar commented Jun 15, 2020

Refactor Flask-AppBuilder SQLAlchemy Interface query

@dpgaspar dpgaspar marked this pull request as ready for review June 15, 2020 15:43
@dpgaspar dpgaspar merged commit c5ca06b into master Jul 2, 2020
@dpgaspar dpgaspar deleted the refactor/interface-query branch July 2, 2020 18:35
ashb added a commit to ashb/Flask-AppBuilder that referenced this pull request Oct 22, 2020
The refactor in dpgaspar#1398 changes the `get()` function, and mistakenly
always applied the PK filter, even in the case of composite keys.

(The else block of `if self.is_pk_composite` applied it again, so it was
actually applying the same filter twice, which didn't break anything,
but was not needed)
ashb added a commit to ashb/Flask-AppBuilder that referenced this pull request Oct 22, 2020
The refactor in dpgaspar#1398 changes the `get()` function, and mistakenly
always applied the PK filter, even in the case of composite keys.

(The else block of `if self.is_pk_composite` applied it again, so it was
actually applying the same filter twice, which didn't break anything,
but was not needed)
dpgaspar pushed a commit that referenced this pull request Oct 25, 2020
The refactor in #1398 changes the `get()` function, and mistakenly
always applied the PK filter, even in the case of composite keys.

(The else block of `if self.is_pk_composite` applied it again, so it was
actually applying the same filter twice, which didn't break anything,
but was not needed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant