Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mvc): action confirmation on single show view #1539

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

dpgaspar
Copy link
Owner

@dpgaspar dpgaspar commented Jan 4, 2021

Description

Fixes: #1529

Action confirmation set to None is not respected when using single on a show view

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #1539 (2b9f40e) into master (3d3c251) will increase coverage by 0.32%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1539      +/-   ##
==========================================
+ Coverage   72.75%   73.07%   +0.32%     
==========================================
  Files          46       46              
  Lines        6354     6463     +109     
==========================================
+ Hits         4623     4723     +100     
- Misses       1731     1740       +9     
Flag Coverage Δ
python 73.07% <0.00%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/security/manager.py 59.50% <0.00%> (+1.66%) ⬆️
flask_appbuilder/security/registerviews.py 31.88% <0.00%> (-0.97%) ⬇️
flask_appbuilder/security/views.py 55.96% <ø> (+1.36%) ⬆️
flask_appbuilder/security/mongoengine/models.py 89.33% <0.00%> (-3.73%) ⬇️
flask_appbuilder/models/mongoengine/interface.py 77.50% <0.00%> (-0.39%) ⬇️
flask_appbuilder/api/schemas.py 100.00% <0.00%> (ø)
flask_appbuilder/baseviews.py 89.86% <0.00%> (+0.01%) ⬆️
flask_appbuilder/api/__init__.py 97.59% <0.00%> (+0.02%) ⬆️
flask_appbuilder/models/sqla/interface.py 78.84% <0.00%> (+0.03%) ⬆️
flask_appbuilder/api/convert.py 91.53% <0.00%> (+0.06%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21059f...2b9f40e. Read the comment docs.

@dpgaspar dpgaspar merged commit fab73d3 into master Jan 4, 2021
@dpgaspar dpgaspar deleted the fix/action-confirmation branch January 4, 2021 17:31
@dpgaspar dpgaspar mentioned this pull request Feb 19, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirmation still shown from a record view on an ModelView action
1 participant