Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix errors in BaseModelView docstring #1591

Merged
merged 2 commits into from
Mar 29, 2021
Merged

docs: Fix errors in BaseModelView docstring #1591

merged 2 commits into from
Mar 29, 2021

Conversation

XD-DENG
Copy link
Contributor

@XD-DENG XD-DENG commented Mar 23, 2021

Description

Purely docstring changes. No touch on actual code.

These two docstring errors are affecting:

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #1591 (a9e06db) into master (d04ec3c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1591   +/-   ##
=======================================
  Coverage   75.44%   75.44%           
=======================================
  Files          54       54           
  Lines        7869     7869           
=======================================
  Hits         5937     5937           
  Misses       1932     1932           
Flag Coverage Δ
python 75.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/baseviews.py 89.86% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d04ec3c...a9e06db. Read the comment docs.

@dpgaspar dpgaspar merged commit 399f922 into dpgaspar:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants