Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: related filters with bogus data #1695

Merged
merged 10 commits into from
Sep 13, 2021
Merged

fix: related filters with bogus data #1695

merged 10 commits into from
Sep 13, 2021

Conversation

dpgaspar
Copy link
Owner

@dpgaspar dpgaspar commented Sep 10, 2021

Description

Fixes issue when a user chooses an empty value from a dropdown for a related field then filter apply get's "__None" and this raises an exception on PG and other engines.

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #1695 (31e5555) into master (1bfedc2) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1695      +/-   ##
==========================================
+ Coverage   76.55%   76.67%   +0.12%     
==========================================
  Files          55       55              
  Lines        8061     8091      +30     
==========================================
+ Hits         6171     6204      +33     
+ Misses       1890     1887       -3     
Flag Coverage Δ
python 76.67% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/exceptions.py 100.00% <100.00%> (ø)
flask_appbuilder/models/sqla/filters.py 80.83% <100.00%> (+4.17%) ⬆️
flask_appbuilder/views.py 66.11% <100.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bfedc2...31e5555. Read the comment docs.

@dpgaspar dpgaspar marked this pull request as ready for review September 10, 2021 18:21
@dpgaspar dpgaspar merged commit 5864338 into master Sep 13, 2021
@dpgaspar dpgaspar deleted the fix/mvc-related-filters branch September 13, 2021 11:21
@dpgaspar dpgaspar mentioned this pull request Sep 14, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant