Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Redirect to prev url on login #1747

Merged
merged 5 commits into from
Dec 2, 2021

Conversation

geido
Copy link
Contributor

@geido geido commented Nov 30, 2021

Description

Adds the ability to redirect to a URL as defined in the query params next_url after login.

ADDITIONAL INFORMATION

@dpgaspar dpgaspar self-requested a review November 30, 2021 12:44
Copy link
Owner

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add it to AuthOIDView also

@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #1747 (c83c25c) into master (071e66b) will decrease coverage by 0.04%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1747      +/-   ##
==========================================
- Coverage   76.80%   76.76%   -0.05%     
==========================================
  Files          56       56              
  Lines        8115     8124       +9     
==========================================
+ Hits         6233     6236       +3     
- Misses       1882     1888       +6     
Flag Coverage Δ
python 76.76% <33.33%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/security/views.py 62.16% <33.33%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f726f8a...c83c25c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants