Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: required roles on user form not showing error msg #1772

Merged
merged 1 commit into from
Jan 6, 2022
Merged

fix: required roles on user form not showing error msg #1772

merged 1 commit into from
Jan 6, 2022

Conversation

dpgaspar
Copy link
Owner

@dpgaspar dpgaspar commented Jan 6, 2022

Description

Small fix for #1758, where the error message (shown by the browser) is not show to the user, not adding a new user without any information.

The console log shows:

An invalid form control with name='roles' is not focusable.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@dpgaspar dpgaspar merged commit 985b1b7 into master Jan 6, 2022
@dpgaspar dpgaspar deleted the fix/role-required branch January 6, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dpgaspar