Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(fab_cli): tag tests that need internet so they can be skipped #1880

Merged
merged 3 commits into from
Jul 29, 2022

Conversation

jnahmias
Copy link
Contributor

@jnahmias jnahmias commented Jul 3, 2022

tag tests that need to download the FAB-Skeleton with 'needs_inet'. This will
allow them to easily be skipped when running in an environment that doesn't
have internet connectivity, such as the Debian build servers.

@jnahmias jnahmias changed the title [test] tag tests that need internet so they can be skipped test - tag tests that need internet so they can be skipped Jul 3, 2022
@codecov
Copy link

codecov bot commented Jul 3, 2022

Codecov Report

Merging #1880 (c0a0277) into master (328adb6) will decrease coverage by 0.10%.
The diff coverage is n/a.

❗ Current head c0a0277 differs from pull request most recent head b521672. Consider uploading reports for the commit b521672 to get more accurate results

@@            Coverage Diff             @@
##           master    #1880      +/-   ##
==========================================
- Coverage   77.74%   77.64%   -0.11%     
==========================================
  Files          70       70              
  Lines        8560     8556       -4     
==========================================
- Hits         6655     6643      -12     
- Misses       1905     1913       +8     
Flag Coverage Δ
python 77.64% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/base.py 78.05% <0.00%> (-2.95%) ⬇️
flask_appbuilder/api/__init__.py 96.40% <0.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2a1e11...b521672. Read the comment docs.

@jnahmias jnahmias changed the title test - tag tests that need internet so they can be skipped test(api): tag tests that need internet so they can be skipped Jul 3, 2022
tag tests that need to download the FAB-Skeleton with 'needs_inet'. This will
allow them to easily be skipped when running in an environment that doesn't
have internet connectivity, such as the Debian build servers.
@jnahmias jnahmias changed the title test(api): tag tests that need internet so they can be skipped test(fab_cli): tag tests that need internet so they can be skipped Jul 3, 2022
@dpgaspar dpgaspar merged commit 0752e5e into dpgaspar:master Jul 29, 2022
@jnahmias jnahmias deleted the tag_internet_tests branch July 29, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants