Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump upper bound on marshmallow-sqlalchemy #1905

Closed
wants to merge 1 commit into from
Closed

chore: Bump upper bound on marshmallow-sqlalchemy #1905

wants to merge 1 commit into from

Conversation

tm-drtina
Copy link
Contributor

Description

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

Copy link
Contributor

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.28.1 removed the Deprecation warning.

The only change of note between 0.27 and 0.28 is:

  • Drop support for Python 3.6, which is EOL.
  • Drop support for SQLAlchemy 1.2, which is EOL.

Looks good to me @dpgaspar

@spike77453
Copy link
Contributor

It's not only the deprecation warning that was removed with marshmallow-sqlalchemy 0.28.1, distutils.version.LooseVersion was replaced with packaging.version.Version: marshmallow-code/marshmallow-sqlalchemy@1826a47

marshmallow-sqlalchemy < 0.28.1 no longer works on Python 3.12 since distutils was removed (see PEP 632) which in turn means that Flask-AppBuilder currently doesn't work on Python 3.12 out of the box.

Haven't noticed any issues running Flask-AppBuilder 4.3.10 with marshmallow-sqlalchemy 0.28.1 @dpgaspar

@dpgaspar
Copy link
Owner

ok, can you fix current conflicts?

@spike77453
Copy link
Contributor

Since I cannot edit this pull requests I've resubmitted the changes as #2191.

@tm-drtina tm-drtina closed this Jun 9, 2024
@tm-drtina tm-drtina deleted the update-marshmallow-sqlalchemy branch June 9, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants