Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Replace deprecated attachment_filename #1956

Merged
merged 1 commit into from
Dec 9, 2022
Merged

fix: Replace deprecated attachment_filename #1956

merged 1 commit into from
Dec 9, 2022

Conversation

steve-embling
Copy link
Contributor

Description

Replace attachment_filename with download_name, as it has been removed from flask. Fixes #1947

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

dpgaspar
dpgaspar approved these changes Dec 9, 2022
View reviewed changes
Copy link
Owner

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@dpgaspar dpgaspar merged commit 38306e5 into dpgaspar:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgaspar dpgaspar dpgaspar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Download issue in view.py
2 participants
@steve-embling @dpgaspar