Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade Select2 to4.0.13 #1968

Merged
merged 2 commits into from
Dec 21, 2022
Merged

fix: upgrade Select2 to4.0.13 #1968

merged 2 commits into from
Dec 21, 2022

Conversation

n1k9
Copy link
Contributor

@n1k9 n1k9 commented Dec 21, 2022

Description

Change Select2 version to fix securty issue #1949

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@n1k9 n1k9 changed the title Fix Select2 4.0.13 fix: upgrade Select2 to4.0.13 Dec 21, 2022
Copy link
Owner

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #1968 (98a52b0) into master (a6fd86a) will increase coverage by 1.58%.
The diff coverage is 88.57%.

@@            Coverage Diff             @@
##           master    #1968      +/-   ##
==========================================
+ Coverage   70.79%   72.38%   +1.58%     
==========================================
  Files          62       71       +9     
  Lines        7163     8466    +1303     
==========================================
+ Hits         5071     6128    +1057     
- Misses       2092     2338     +246     
Flag Coverage Δ
python 72.38% <88.57%> (+1.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/views.py 63.85% <ø> (ø)
flask_appbuilder/security/manager.py 74.40% <50.00%> (-0.06%) ⬇️
flask_appbuilder/security/utils.py 66.66% <66.66%> (ø)
flask_appbuilder/security/views.py 62.46% <77.77%> (+0.41%) ⬆️
flask_appbuilder/models/sqla/interface.py 81.86% <93.75%> (+3.39%) ⬆️
flask_appbuilder/security/sqla/manager.py 75.18% <94.44%> (+0.85%) ⬆️
flask_appbuilder/__init__.py 100.00% <100.00%> (ø)
flask_appbuilder/api/__init__.py 96.38% <100.00%> (+0.01%) ⬆️
flask_appbuilder/filters.py 89.79% <0.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dpgaspar dpgaspar merged commit 3c0ac01 into dpgaspar:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants