Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updated LDAP Documentation #1988

Merged
merged 3 commits into from
Feb 23, 2023
Merged

Conversation

a-gerhard
Copy link
Contributor

Description

After spending some time trying to set up Apache Airflow with LDAP-over-TLS authentication and running into multiple TLS issues, I added some missing documentation that would helped me.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@a-gerhard a-gerhard changed the title Updated LDAP Documentation docs: Updated LDAP Documentation Jan 31, 2023
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #1988 (967d66e) into master (57e9d10) will decrease coverage by 33.24%.
The diff coverage is n/a.

❗ Current head 967d66e differs from pull request most recent head d7f5c42. Consider uploading reports for the commit d7f5c42 to get more accurate results

@@             Coverage Diff             @@
##           master    #1988       +/-   ##
===========================================
- Coverage   78.10%   44.87%   -33.24%     
===========================================
  Files          71       71               
  Lines        8611     8479      -132     
===========================================
- Hits         6726     3805     -2921     
- Misses       1885     4674     +2789     
Flag Coverage Δ
python 44.87% <ø> (-33.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/security/sqla/apis/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
flask_appbuilder/security/sqla/apis/role/schema.py 0.00% <0.00%> (-100.00%) ⬇️
flask_appbuilder/security/sqla/apis/user/schema.py 0.00% <0.00%> (-100.00%) ⬇️
...ask_appbuilder/security/sqla/apis/role/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
...ask_appbuilder/security/sqla/apis/user/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
...ask_appbuilder/security/sqla/apis/view_menu/api.py 0.00% <0.00%> (-100.00%) ⬇️
...sk_appbuilder/security/sqla/apis/permission/api.py 0.00% <0.00%> (-100.00%) ⬇️
...sk_appbuilder/security/sqla/apis/user/validator.py 0.00% <0.00%> (-100.00%) ⬇️
...ppbuilder/security/sqla/apis/view_menu/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
...pbuilder/security/sqla/apis/permission/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
... and 46 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Owner

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

left just a really small comment

docs/config.rst Outdated
+----------------------------------------+--------------------------------------------+-----------+
| AUTH_LDAP_TLS_CACERTFILE | CA Certificate file to check peer | No |
| | certificate | |
| | certificate. FIle must be PEM-encoded | |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File must be PEM-encoded (change the upper I)

@dpgaspar dpgaspar merged commit 0132aad into dpgaspar:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants