Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unused parameter from QuerySelectMultipleField instantiation #1991

Merged

Conversation

Dosenpfand
Copy link
Contributor

Description

Remove the unused parameter allow_blank from the instantiation of the QuerySelectMultipleField object to avoid throwing the warning:

fields.py:179: UserWarning: allow_blank=True does not do anything for QuerySelectMultipleField.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #1991 (97f94e1) into master (3d17741) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1991      +/-   ##
==========================================
- Coverage   78.13%   78.10%   -0.03%     
==========================================
  Files          71       71              
  Lines        8612     8611       -1     
==========================================
- Hits         6729     6726       -3     
- Misses       1883     1885       +2     
Flag Coverage Δ
python 78.10% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/forms.py 98.16% <ø> (-0.02%) ⬇️
flask_appbuilder/fields.py 69.06% <0.00%> (-1.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Owner

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dpgaspar dpgaspar merged commit 5b50d42 into dpgaspar:master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants