Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactored logging functions to consistently use lazy interpolation #2071

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

xuganyu96
Copy link
Contributor

Description

This PR addresses issue #2062. All code changes are refactoring logging function calls to use lazy interpolation instead of string formatting.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@dpgaspar dpgaspar changed the title refactor Refactored logging functions to consistently use lazy interpolation refactor: Refactored logging functions to consistently use lazy interpolation Jun 29, 2023
@dpgaspar
Copy link
Owner

This is awesome! thank you

can you please run black flask_appbuilder to fix the lint issues

Copy link
Owner

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run black to fix lint issue

@xuganyu96
Copy link
Contributor Author

Thank you for the tip! Looking forward to have my first contribution here :)

@dpgaspar dpgaspar merged commit fbb2af7 into dpgaspar:master Jul 10, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants