Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove email_validator constraint #2167

Merged

Conversation

marcuslimdw
Copy link
Contributor

@marcuslimdw marcuslimdw commented Nov 22, 2023

Description

email-validator is a transitive dependency (of WTForms), but the <2 constraint isn't actually necessary.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f00efc) 79.71% compared to head (757aa98) 79.57%.
Report is 2 commits behind head on master.

❗ Current head 757aa98 differs from pull request most recent head feedc6a. Consider uploading reports for the commit feedc6a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2167      +/-   ##
==========================================
- Coverage   79.71%   79.57%   -0.15%     
==========================================
  Files          72       72              
  Lines        8990     8982       -8     
==========================================
- Hits         7166     7147      -19     
- Misses       1824     1835      +11     
Flag Coverage Δ
python 79.57% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpgaspar dpgaspar self-requested a review January 25, 2024 14:20
@dpgaspar dpgaspar merged commit fb40d73 into dpgaspar:master Feb 15, 2024
11 checks passed
@marcuslimdw marcuslimdw deleted the remove-email-validator-constraint branch February 18, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants