Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AUTH_REMOTE_USER_ENV_VAR config key for auth REMOTE_USER type #2193

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

dpgaspar
Copy link
Owner

@dpgaspar dpgaspar commented Feb 8, 2024

Description

A simple solution for: #2014

Add a new config key AUTH_REMOTE_USER_ENV_VAR to allow for users to set their own WSGI env var that holds the current username.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9123fcb) 79.57% compared to head (23cdc5e) 79.71%.

Files Patch % Lines
flask_appbuilder/security/views.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2193      +/-   ##
==========================================
+ Coverage   79.57%   79.71%   +0.13%     
==========================================
  Files          72       72              
  Lines        8985     8990       +5     
==========================================
+ Hits         7150     7166      +16     
+ Misses       1835     1824      -11     
Flag Coverage Δ
python 79.71% <83.33%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpgaspar dpgaspar merged commit 6f00efc into master Feb 8, 2024
14 checks passed
@dpgaspar dpgaspar deleted the feat/remote-user-config branch February 8, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant