Docker Compose reorganized #437
Conversation
jimmeak
force-pushed
the
found/docker
branch
2 times, most recently
from
b5083ff
to
32808e6
Compare
jimmeak
force-pushed
the
found/docker
branch
from
32808e6
to
b75e57a
Compare
|
|
||
| RUN pip install --upgrade pip | ||
|
|
||
| ADD requirements.txt . |
There was a problem hiding this comment.
Are we going to be keeping this and top-level requirements in sync? Wouldn't it be better to just add the top-level one?
There was a problem hiding this comment.
It seemed to me that the context specified in docker compose yaml file does not let us to load the root lvl requirements. It always gave me an error. I tried it now to be sure and now it works with ADD ./../../requirements.txt, so it seems we can use both.
Which file is better to keep? If we would use only docker, I'd say let's use this one. But we have also possibility to run the app without docker, right? Therefore it would be bad if it were only in docker directory, so I'd keep the root file and this could go away. What do you think?
| @@ -0,0 +1 @@ | |||
| FROM mariadb:latest | |||
There was a problem hiding this comment.
I'd definitely use a specific version that is on prod. That's currently mysql-5.5, but find the oldest version you can and we'll keep them in sync once we upgrade :)
If there is a way to keep it in sync with the terraform version, that would be golden :)
There was a problem hiding this comment.
I added version 10.0 that should be more or less compatible with mysql-5.5. For local developing mysql 5.5 and mariadb 5.5 do not have official docker images for arm64v8, do they? At least for it is this error:
Special directory .docker for organization of the code.
Fix: Dynamic exposing of the ports for Selenium are not needed in local env and they caused problems.