-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add E2E tests for cases that peers going offline #3524
Open
BruceAko
wants to merge
1
commit into
dragonflyoss:main
Choose a base branch
from
BruceAko:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BruceAko
changed the title
feat: add E2E tests for cases that peers going offline
[WIP] feat: add E2E tests for cases that peers going offline
Sep 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3524 +/- ##
==========================================
- Coverage 51.85% 51.66% -0.20%
==========================================
Files 190 190
Lines 20488 20562 +74
==========================================
- Hits 10625 10624 -1
- Misses 9054 9128 +74
- Partials 809 810 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
BruceAko
force-pushed
the
main
branch
4 times, most recently
from
September 25, 2024 05:11
bd92139
to
4eab162
Compare
BruceAko
force-pushed
the
main
branch
16 times, most recently
from
September 26, 2024 03:12
0132600
to
a86b706
Compare
BruceAko
force-pushed
the
main
branch
9 times, most recently
from
September 26, 2024 09:58
1cb2a2f
to
c4f9252
Compare
BruceAko
changed the title
[WIP] feat: add E2E tests for cases that peers going offline
feat: add E2E tests for cases that peers going offline
Sep 26, 2024
BruceAko
force-pushed
the
main
branch
6 times, most recently
from
September 26, 2024 14:50
815807d
to
e59c3ba
Compare
gaius-qi
requested changes
Sep 27, 2024
BruceAko
force-pushed
the
main
branch
5 times, most recently
from
September 27, 2024 15:28
7ef9cee
to
b2a350f
Compare
Signed-off-by: BruceAko <chongzhi@hust.edu.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verifies that Scheduler can clear offline peer metadata when the host exits normally/abnormally by following steps:
Related Issue
#3523
Motivation and Context
Earlier we have added functionality so that hosts send
LeaveHost()
requests to the Scheduler on normal exit and hosts on abnormal exit are also sensed by the Scheduler GC after a set amount of time and the metadata is cleared. Now, we are going to add E2E tests to verify that this functionality is correct.Types of changes
Checklist