Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased test coverage. #115

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Increased test coverage. #115

merged 4 commits into from
Jul 25, 2024

Conversation

tannguyen04
Copy link
Contributor

@tannguyen04 tannguyen04 commented Jul 23, 2024

Checklist before requesting a review

closes #113

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.66%. Comparing base (ef34030) to head (a830ce1).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #115       +/-   ##
===========================================
+ Coverage   71.23%   91.66%   +20.42%     
===========================================
  Files           4        4               
  Lines         226      228        +2     
===========================================
+ Hits          161      209       +48     
+ Misses         65       19       -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tannguyen04 tannguyen04 marked this pull request as ready for review July 24, 2024 04:05
@AlexSkrypnyk AlexSkrypnyk merged commit 7bd4a09 into main Jul 25, 2024
1 check passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/increase-coverage branch July 25, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase test coverage
3 participants