Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#124] Added support for CKEditor 5. #168

Merged
merged 4 commits into from
Dec 29, 2023

Conversation

tannguyen04
Copy link
Contributor

@tannguyen04 tannguyen04 commented Dec 28, 2023

#124

  • I have formatted the subject to include ticket number
    as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was
    done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and
    they passed
  • I have provided screenshots, where applicable

- Enable wysiwyg test for javascript driver.
@tannguyen04 tannguyen04 changed the title Feature/support ckeditor v5 [#124] Feature/support ckeditor v5 Dec 28, 2023
@AlexSkrypnyk AlexSkrypnyk changed the title [#124] Feature/support ckeditor v5 [#124] Added support for CKEditor 5. Dec 28, 2023
Copy link
Member

@AlexSkrypnyk AlexSkrypnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannguyen04

Could you please use the code from #124 (comment)

That implementation supports non-js drivers.

also, CKEditor support is not required.

@AlexSkrypnyk
Copy link
Member

@tannguyen04
could you please confirm that cke5 is used in the d10 fixture site.

@AlexSkrypnyk AlexSkrypnyk merged commit 08c7ebf into drevops:main Dec 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants