Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to specify relative time in seconds in DateTrait. #241

Merged
merged 7 commits into from
Jul 15, 2024

Conversation

tannguyen04
Copy link
Contributor

@tannguyen04 tannguyen04 commented Jul 8, 2024

Checklist before requesting a review

closes #228

  • I have formatted the subject to include ticket number
    as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was
    done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and
    they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

@tannguyen04 tannguyen04 marked this pull request as ready for review July 8, 2024 07:59
Copy link
Member

@AlexSkrypnyk AlexSkrypnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannguyen04
I understand what you tried to do with BASETIMESTAMP, but this is not the way.

Please make the following changes:

  1. Remove base timestamp and introduce dateNow() method that will be returning the time().
  2. Override this method to return a preset value in FeatureContext.php - this will allow to mock the current timestamp.

@tannguyen04 tannguyen04 changed the title Made relative time support in second and specific base timestamp. Made relative time support in second. Jul 15, 2024
@AlexSkrypnyk AlexSkrypnyk changed the title Made relative time support in second. Added support to specify relative time in seconds in DateTrait. Jul 15, 2024
@AlexSkrypnyk AlexSkrypnyk enabled auto-merge (squash) July 15, 2024 03:30
@AlexSkrypnyk AlexSkrypnyk merged commit 677627e into main Jul 15, 2024
1 check passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/relative-time-not-specificed-seconds branch July 15, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relative time cannot be specified in seconds
2 participants