Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added steps: scroll to element and check element at the top of page. #257

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

tannguyen04
Copy link
Contributor

@tannguyen04 tannguyen04 commented Jul 31, 2024

Checklist before requesting a review

#251

  • I have formatted the subject to include ticket number
    as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was
    done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and
    they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

@tannguyen04
Copy link
Contributor Author

Before
1722395880 js feature_37

After
1722395880 js feature_40

@tannguyen04 tannguyen04 marked this pull request as ready for review July 31, 2024 03:33
Copy link
Member

@AlexSkrypnyk AlexSkrypnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert the tags on scenarios and add the steps to the readme file

@AlexSkrypnyk AlexSkrypnyk added requires more work PR: Requires more work Pull request was reviewed and reviver(s) asked to work further on the pull request and removed requires more work labels Jul 31, 2024
@AlexSkrypnyk AlexSkrypnyk merged commit a8cb789 into main Jul 31, 2024
1 check passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/scroll-to-element-step branch July 31, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Requires more work Pull request was reviewed and reviver(s) asked to work further on the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants