Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the PsySH version check #2822

Merged
merged 1 commit into from
Jun 23, 2017

Conversation

pfrenssen
Copy link
Member

I had noticed that launching drush php is often inexplicably slow, taking up to 30 seconds to launch. I've now discovered that this happens when I am on a slow mobile connection. PsySH has a feature to check for updates, and by default this checks once per week. Unfortunately since we are using a "bundled" version and generate the configuration on the fly when launching it this performs the update check every single time it is launched.

I can understand the usefulness of this feature when using PsySH standalone, but I think this version check is pretty pointless in our typical use case. PsySH is a dependency of Drush which is a dev dependency of Drupal which is a dependency of a custom web project which will typically only be updated whenever a security update is available. I don't think most maintainers of Drupal sites are going to jump at the opportunity to update their production instances just because this niche developer tool has a new update 😛

I had a look to port this to the master branch too but it was not immediately clear to me where the PsySH configuration was being generated.

@damiankloip
Copy link
Contributor

Yes, I was thinking about disabling this anyways.. It doesn't make much sense when most people will be using x version of drush, so the psysh version will be locked anyway.

Thanks @pfrenssen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants