Site-set / use functioning again #2989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We commented out a test for this. Maybe Greg and you can modernize it and re-enable? Thanks Joel. |
|
We were discussing that at lunch a bit, thanks I’ll do that this afternoon
in the sprint continued.
|
|
Tests added and passing locally |
joelpittet
force-pushed
the
site-set
branch
from
4bd002d
to
c6975f4
Compare
…mand names in comments
joelpittet
force-pushed
the
site-set
branch
from
c6975f4
to
a7ddab8
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.