Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Fix #3071. Add sql:fetch command #3258

Closed
wants to merge 2 commits into from
Closed

WIP Fix #3071. Add sql:fetch command #3258

wants to merge 2 commits into from

Conversation

weitzman
Copy link
Member

Per #3071, make it easy to get data out of the Drupal DB in any format.

The command here can be finished easily but the output formatter system has no way to handle variable field input AFAICT. We ran into this limitation once before, I think.

@weitzman weitzman mentioned this pull request Dec 18, 2017
@weitzman
Copy link
Member Author

Arbitrary columns is also needed in migrate-messages command which shows rows with keys of dynamic name and number

@weitzman
Copy link
Member Author

weitzman commented Apr 1, 2019

@greg-1-anderson
Copy link
Member

It's probably a mistake to use RowsOfFields for sql dumps. The library does a lot of processing on the rows, so this would bog down if someone used it to fetch a large database. It's probably better to just return the data as a string and let sql functions such as the one mentioned above do the formatting.

@weitzman
Copy link
Member Author

weitzman commented Apr 1, 2019

OK, lets close this with the noted workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants