Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SqlTableSelectionTrait.php so it is usable by non SqlBase derivatives #3340

Merged
merged 1 commit into from
Feb 1, 2018
Merged

Refactor SqlTableSelectionTrait.php so it is usable by non SqlBase derivatives #3340

merged 1 commit into from
Feb 1, 2018

Conversation

weitzman
Copy link
Member

@weitzman weitzman commented Feb 1, 2018

No description provided.

Skarlso
Skarlso approved these changes Feb 1, 2018
View reviewed changes
Copy link

@Skarlso Skarlso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much needed to have not to override getExpandedTableSelection but provide a list of our own creation.

@weitzman weitzman merged commit 87d3c36 into master Feb 1, 2018
@weitzman weitzman deleted the tableSelectionRefactor branch February 1, 2018 16:56
@violinist-bot violinist-bot mentioned this pull request Oct 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skarlso Skarlso Skarlso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weitzman @Skarlso