Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look in config for sites-subdir #3589

Closed
wants to merge 1 commit into from

Conversation

neclimdul
Copy link
Contributor

Fix #3495

Not sure if this is the "correct" fix but it fixes the problem.

@weitzman
Copy link
Member

Would be ideal to get a review from @greg-1-anderson since he made #2982

@weitzman
Copy link
Member

Please see if #3495 (comment) fixes this for you.

@greg-1-anderson
Copy link
Member

This should be solved via configuration injection, as suggested in #3495 (comment).

If the issue is that only command-specific options are working here, and a global sites-subdir configuration option is not respected, we should investigate that and fix it in config injection. We don't want to add explicit calls to config->get() when it is possible to inject the value.

@neclimdul
Copy link
Contributor Author

@greg-1-anderson that seems to be the case. Also, sites subdir resolution fails to fallback on default when a URI is provided. fix for that here #3591

@neclimdul
Copy link
Contributor Author

I'm not sure how "If the issue is that only command-specific options are working here, and a global sites-subdir configuration option is not respected" should be addressed but I think the original issue has been addressed pretty thoroughly so closing this.

@neclimdul neclimdul closed this Jun 25, 2018
@neclimdul neclimdul deleted the fix-3495 branch June 25, 2018 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drush 9 site-install with drupalvm not finding sites-subdir on single site install
3 participants