-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport static create factory commands for Drush 11.x #5565
Conversation
Code looks good.
|
I'll do 3 here now; maybe 1 and 2 should be follow-on work, done in 12.x branch first. |
Well, 4) makes the composer.json stanza unneeded for modules that choose to use create(). Want to make sure we dont error or warn in this case. |
We should probably just remove the debug message about the composer.json stanza. That feature is going away anyway. |
Ah, you're right, there's no reason to encourage folks to pin down the version selection in composer.json even in the 11.x branch. We can just take that out. |
…r.json file for a module with Drush commands.
a3530b5
to
a643a36
Compare
Still in progress on 2 and 3; will work on them in the 12.x branch first, then move here. |
12.x branch already used static create when creating Drush command files; ported that code here. |
Docs updates also backported; that should take care of 1-4; let me know if you notice any other gaps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This backports static create factory command handlers to Drush 11.x, supporting commands, hooks and info alterers for PSR-4 discovered commands and module commands. Does not include the port of Drush command implementations to use static create factory methods, or any of the modernized classes or refactoring from the 12.x version.
Having this basic capability in Drush 11.x will make module maintainers more likely to adopt static create factory commands earlier, since this will allow them to work across two major versions of Drush.